Merged
Conversation
WojciechKusa
requested review from
galtay,
hakunanatasha,
jason-fries,
leonweber,
ruisi-su and
sunnnymskang
as code owners
galtay
reviewed
Mar 31, 2022
galtay
requested changes
Apr 3, 2022
Collaborator
galtay
left a comment
galtay
left a comment
There was a problem hiding this comment.
changing review to "request changes" for easier tracking in PR list
Collaborator
|
@galtay Assigned for your review since you have some familiarity with the PR; please ping me if you need help |
Collaborator
|
@WojciechKusa is this still on your radar? |
Collaborator
Author
|
Yes, I am still working on it |
Collaborator
|
@WojciechKusa will unit-tests still fail if you call them via the |
# Conflicts: # biodatasets/scielo/scielo.py
Collaborator
Author
|
I changed the
You can take a look one more time @galtay @hakunanatasha |
galtay
requested changes
Apr 12, 2022
Co-authored-by: Gabriel Altay <gabriel.altay@gmail.com>
Co-authored-by: Gabriel Altay <gabriel.altay@gmail.com>
there were 1 or 2 lingering inconsistencies so just converted everything to underscore
galtay
approved these changes
Apr 13, 2022
Collaborator
|
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #49
NOTE 1:
bigbio_t2t schema doesn't allow more than two texts in text-to-text schema. en-pt-es translation is not implemented using the bigbio schema