-
Notifications
You must be signed in to change notification settings - Fork 119
Closes #25 #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #25 #357
Conversation
…nswer for PQA-Unlabeled
hakunanatasha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the images.
I'm having trouble running the unittests for pqaa and pqau but pqal passes - when I look at google I see it limits the download because of size - can you check if these work?
|
Hi @hakunanatasha, same as in the other PR, I have deleted the two image files here. I tested on I tested some other datasets (mediqa_qa, mediqa_rqe, pubmed_qa, paramed, pico_extraction, medhop. scital, and mqp) using the |
|
@SamuelCahyawijaya very interesting - yes if that's the case, let's update the reqs. |
…emove LONG_ANSWER, update question type to yesno
|
@hakunanatasha : I have added the 10-fold configs for source and bigbio schemas. The subset_id for |
…emove LONG_ANSWER, update question type to yesno
|
don't worry about the images (we can just merge this and then add the images back right after) |
… naming for the subset_id following bigbio convention, update None to BigBioValues.NULL on the bigbio schema
|
Hi @SamuelCahyawijaya, I think I understand this dataset a bit better now. Are all the BigBio Q/A schemas using the yes/no answers? It seems that we might also be able to support |
format, remove print, add TODO
* add back images that were removed in #357 * oops! rename images
|
Hi @galtay, yes, you are right. The dataset can be utilized to support Let me know if later we plan to implement a different task / QA type for this. I can help to implement that part. |
Please name your PR after the issue it closes. You can use the following line: "Closes #ISSUE-NUMBER" where you replace the ISSUE-NUMBER with the one corresponding to your dataset.
If the following information is NOT present in the issue, please populate:
Checkbox
biodatasets/my_dataset/my_dataset.py(please use only lowercase and underscore for dataset naming)._CITATION,_DATASETNAME,_DESCRIPTION,_HOMEPAGE,_LICENSE,_URLs,_SUPPORTED_TASKS,_SOURCE_VERSION, and_BIGBIO_VERSIONvariables._info(),_split_generators()and_generate_examples()in dataloader script.BUILDER_CONFIGSclass attribute is a list with at least oneBigBioConfigfor the source schema and one for a bigbio schema.datasets.load_datasetfunction.python -m tests.test_bigbio biodatasets/my_dataset/my_dataset.py.Note: Need to specify a specific
subset_id, i.e., pqal, pqau, and pqaa, to run the unit test.