Skip to content

Closes #235#402

Merged
sg-wbi merged 5 commits intobigscience-workshop:masterfrom
sidkiblawi:ehr_rel
Apr 11, 2022
Merged

Closes #235#402
sg-wbi merged 5 commits intobigscience-workshop:masterfrom
sidkiblawi:ehr_rel

Conversation

@sidkiblawi
Copy link
Copy Markdown
Contributor

Closes #235

Checkbox

  • Confirm that this PR is linked to the dataset issue.
  • Create the dataloader script biodatasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
  • Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _BIGBIO_VERSION variables.
  • Implement _info(), _split_generators() and _generate_examples() in dataloader script.
  • Make sure that the BUILDER_CONFIGS class attribute is a list with at least one BigBioConfig for the source schema and one for a bigbio schema.
  • Confirm dataloader script works with datasets.load_dataset function.
  • Confirm that your dataloader script passes the test suite run with python -m tests.test_bigbio biodatasets/my_dataset/my_dataset.py.
  • If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

Copy link
Copy Markdown
Collaborator

@sg-wbi sg-wbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sidkiblawi Thank you for your contribution! Could you please check out my comments? Thanks.

Comment thread biodatasets/ehr_rel/ehr_rel.py Outdated
Comment thread biodatasets/ehr_rel/ehr_rel.py
@sg-wbi sg-wbi self-assigned this Apr 11, 2022
Copy link
Copy Markdown
Collaborator

@sg-wbi sg-wbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You got it! Thank you for your contribution @sidkiblawi! I'm closing this!

@sg-wbi sg-wbi merged commit 46f7672 into bigscience-workshop:master Apr 11, 2022
@sidkiblawi sidkiblawi deleted the ehr_rel branch April 11, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create dataset loader for EHR-Rel

2 participants