Skip to content

refactor: eval tqdm without newline#28

Merged
tianjianjiang merged 3 commits intobigscience-workshop:masterfrom
tianjianjiang:refactor-eval_tqdm_without_newline
Sep 6, 2021
Merged

refactor: eval tqdm without newline#28
tianjianjiang merged 3 commits intobigscience-workshop:masterfrom
tianjianjiang:refactor-eval_tqdm_without_newline

Conversation

@tianjianjiang
Copy link
Copy Markdown
Collaborator

Otherwise eval newlines will be flooding the output of (Colab) notebook.

https://tqdm.github.io/docs/tqdm/#__init__

position: int, optional
Specify the line offset to print this bar (starting from 0) Automatic if unspecified. Useful to manage multiple bars at once (eg, from threads).

Two side notes:
1. Python 3.7.11 is for Colab;
2. Poetry is optional for managing venv and dependencies, but syncing
   with requirements(-dev).txt must be done manually for the time being.
@tianjianjiang tianjianjiang self-assigned this Sep 6, 2021
@tianjianjiang tianjianjiang added this to the Break-in Period milestone Sep 6, 2021
@tianjianjiang tianjianjiang requested a review from SaulLu September 6, 2021 13:39
@tianjianjiang tianjianjiang force-pushed the refactor-eval_tqdm_without_newline branch from 2758fb6 to 0aab04d Compare September 6, 2021 13:40
@tianjianjiang tianjianjiang added the enhancement New feature or request label Sep 6, 2021
Copy link
Copy Markdown
Collaborator

@SaulLu SaulLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks

@tianjianjiang tianjianjiang merged commit 7759f98 into bigscience-workshop:master Sep 6, 2021
@tianjianjiang tianjianjiang deleted the refactor-eval_tqdm_without_newline branch September 6, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants