Skip to content

fix: process pool's fork safety issue since macOS High Sierra #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: process pool's fork safety issue since macOS High Sierra #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions promptsource/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import argparse
import textwrap
from multiprocessing import Manager, Pool
from itertools import repeat
from multiprocessing import Manager
from multiprocessing.pool import ThreadPool

import pandas as pd
import plotly.express as px
Expand Down Expand Up @@ -138,11 +140,11 @@ def show_text(t, width=WIDTH, with_markdown=False):
all_infos = manager.dict()
all_datasets = list(set([t[0] for t in template_collection.keys]))

def get_infos(d_name):
def get_infos(d_name, all_infos):
all_infos[d_name] = get_dataset_infos(d_name)

pool = Pool(processes=len(all_datasets))
pool.map(get_infos, all_datasets)
pool = ThreadPool(processes=len(all_datasets))
pool.starmap(get_infos, zip(all_datasets, repeat(all_infos)))
pool.close()
pool.join()

Expand Down