Fix seqio import for story cloze #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: zaidalyafeai <alyafey22@gmail.com>
Co-authored-by: zaidalyafeai <alyafey22@gmail.com>
Co-authored-by: zaidalyafeai <alyafey22@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintegrates
story_clozewhich a dataset that is not yet merged into HF/datasets' master.Lots of similarities #443 (that we reverted b32f2de because it was making the test fail).
Ultimately, once
story_clozeis merged in huggingface dataset master, we won't need these custom hacks anymore.With these corrections:
test_templates.py) are not longer failingimport seqio; import promptsource.seqio_taskswithout crashing (which is necessary for the training)Note: the test
show_new_templatesis failing becausestory_clozerequires manual download which is a non supported case of this test