Skip to content

remove custom datasets (story_cloze) #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2021
Merged

remove custom datasets (story_cloze) #549

merged 2 commits into from
Oct 17, 2021

Conversation

@VictorSanh
Copy link
Member

@VictorSanh VictorSanh commented Oct 15, 2021

fixes #541

stephenbach
stephenbach approved these changes Oct 17, 2021
View reviewed changes
Copy link
Member

@stephenbach stephenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. App runs including helicopter view. I still get ManualDownloadError for story_cloze after upgrading to datasets 1.13.3. Is that expected?

@VictorSanh
Copy link
Member Author

VictorSanh commented Oct 17, 2021

thanks!
yes, story_cloze requires manual download anyway

@VictorSanh
Copy link
Member Author

VictorSanh commented Oct 17, 2021

moving ahead and merging

@VictorSanh VictorSanh merged commit 00b0f0b into main Oct 17, 2021
@VictorSanh VictorSanh mentioned this pull request Oct 18, 2021
Closed
@VictorSanh VictorSanh deleted the remove_custom_datasets branch June 25, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephenbach stephenbach stephenbach approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

story_cloze remove custom code now that PR was merged into hf datasets

3 participants

@VictorSanh @stephenbach