fix: for sent_comp, remove single quotes and add the metric of "Other"#669
Conversation
|
Thanks! You can rewrite them as you see fit, e.g., for the last two change compress to expand or something else. Please also give them meaningful names, per the cleaning instructions. |
Understood! I will revise this PR in 8 hours. |
Did you get a chance @tianjianjiang to look into that? |
@stephenbach @VictorSanh I'm terribly sorry. I was caught up in my day job and failed to notice this. I am doing it right away. |
e6f979b to
efb3706
Compare
@stephenbach @VictorSanh I've just pushed a new revision for the above issues. Please also kindly note that the CI error is not about this but #690 |
|
Thank you @tianjianjiang ! Could you rebase? i just pushed a few fixes to the tests/promptsource |
|
i'll let @stephenbach validate the PR |
efb3706 to
2008292
Compare
@VictorSanh +CC @stephenbach Roger that and done! |
The PR fixes:
'''that caused the UI (and probably the training data) to have single quotes around the prompts.A side note:
No offense, but Template_5 and Template_6 make little sense. Because they ask humans to compress headlines. Yet the answers are usually longer than headlines.