Skip to content

fix: for sent_comp, remove single quotes and add the metric of "Other"#669

Merged
stephenbach merged 2 commits intobigscience-workshop:mainfrom
tianjianjiang:fix-sent_comp
Dec 20, 2021
Merged

fix: for sent_comp, remove single quotes and add the metric of "Other"#669
stephenbach merged 2 commits intobigscience-workshop:mainfrom
tianjianjiang:fix-sent_comp

Conversation

@tianjianjiang
Copy link
Copy Markdown
Contributor

@tianjianjiang tianjianjiang commented Nov 30, 2021

The PR fixes:

  • The templates had ''' that caused the UI (and probably the training data) to have single quotes around the prompts.
  • The original paper and the follow up papers use F1 of dependency tree features.

A side note:
No offense, but Template_5 and Template_6 make little sense. Because they ask humans to compress headlines. Yet the answers are usually longer than headlines.

@stephenbach
Copy link
Copy Markdown
Member

Thanks! You can rewrite them as you see fit, e.g., for the last two change compress to expand or something else. Please also give them meaningful names, per the cleaning instructions.

@stephenbach stephenbach self-assigned this Dec 1, 2021
@tianjianjiang
Copy link
Copy Markdown
Contributor Author

Thanks! You can rewrite them as you see fit, e.g., for the last two change compress to expand or something else. Please also give them meaningful names, per the cleaning instructions.

Understood! I will revise this PR in 8 hours.

@VictorSanh
Copy link
Copy Markdown
Member

Thanks! You can rewrite them as you see fit, e.g., for the last two change compress to expand or something else. Please also give them meaningful names, per the cleaning instructions.

Understood! I will revise this PR in 8 hours.

Did you get a chance @tianjianjiang to look into that?

@tianjianjiang
Copy link
Copy Markdown
Contributor Author

Thanks! You can rewrite them as you see fit, e.g., for the last two change compress to expand or something else. Please also give them meaningful names, per the cleaning instructions.

Understood! I will revise this PR in 8 hours.

Did you get a chance @tianjianjiang to look into that?

@stephenbach @VictorSanh I'm terribly sorry. I was caught up in my day job and failed to notice this. I am doing it right away.

@tianjianjiang
Copy link
Copy Markdown
Contributor Author

Thanks! You can rewrite them as you see fit, e.g., for the last two change compress to expand or something else. Please also give them meaningful names, per the cleaning instructions.

@stephenbach @VictorSanh I've just pushed a new revision for the above issues.

Please also kindly note that the CI error is not about this but #690

@VictorSanh
Copy link
Copy Markdown
Member

Thank you @tianjianjiang ! Could you rebase? i just pushed a few fixes to the tests/promptsource

@VictorSanh
Copy link
Copy Markdown
Member

i'll let @stephenbach validate the PR

@tianjianjiang
Copy link
Copy Markdown
Contributor Author

Could you rebase? i just pushed a few fixes to the tests/promptsource

@VictorSanh +CC @stephenbach Roger that and done!

Copy link
Copy Markdown
Member

@stephenbach stephenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@stephenbach stephenbach merged commit f5fc035 into bigscience-workshop:main Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants