Skip to content

Comments

Trims only the first leading space in a SSE field value (#3588)#3589

Merged
1cg merged 1 commit intobigskysoftware:fourfrom
antonlorani:3588-sse-parser-trim-only-single-leading-space
Jan 20, 2026
Merged

Trims only the first leading space in a SSE field value (#3588)#3589
1cg merged 1 commit intobigskysoftware:fourfrom
antonlorani:3588-sse-parser-trim-only-single-leading-space

Conversation

@antonlorani
Copy link

@antonlorani antonlorani commented Dec 14, 2025

Description

Fixes #3588

Testing

Added a new test case to test/tests/end2end/sse.js

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@antonlorani antonlorani force-pushed the 3588-sse-parser-trim-only-single-leading-space branch 2 times, most recently from 60a217e to 3bb6dca Compare December 14, 2025 16:28
@antonlorani antonlorani force-pushed the 3588-sse-parser-trim-only-single-leading-space branch from 3bb6dca to c2cb59e Compare December 14, 2025 16:28
@1cg
Copy link
Contributor

1cg commented Jan 20, 2026

hi @antonlorani we are reviewing this change now, thank you!

@1cg 1cg merged commit 54bf849 into bigskysoftware:four Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants