handle newContent processing of outerMorph that inserts new nodes#3667
Merged
1cg merged 1 commit intobigskysoftware:fourfrom Feb 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During outerMorph swap style we make the newContent for later processing by using the fragment childNodes and adding in the target node so that either the existing morphed node or the newly inserted nodes will always be processed properly. But inside the morph we actually can clone the nodes with importNode() when inserting new nodes leaving the fragment childNodes disconnected and preventing the cloned in node being processed. To solve this I've removed the importNode which was done to prevent parent node mutations and instead captured the parent node children in the for loop to make the loop stable this way.
Corresponding issue:
Testing
Please explain how you tested this change manually, and, if applicable, what new tests you added. If
you're making a change to just the website, you can omit this section.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded