docs: fix SVG viewBox in icon button examples #145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes toggle switch focus rings and un-applies the select height hack from `<select multiple>`.
The svg examples in the components docs file did not set a viewBox on the svg components which resulted them in having a hover target that was much taller than the button in both directions. This change explicitly sets the viewBox of `0 0 24 24` on each svg icon.
Collaborator
|
Thanks for the PR! Since this is entirely docs related, I've re-targeted it to the |
geoffrey-eisenbarth
added a commit
that referenced
this pull request
Nov 10, 2025
docs: fix SVG viewBox in icon button examples. author: @dhartunian (PR #145)
Collaborator
|
@dhartunian Really appreciate this! I had to end up cherry-picking your commit onto Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The svg examples in the components docs file did not set a viewBox on the svg components which resulted them in having a hover target that was much taller than the button in both directions.
This change explicitly sets the viewBox of
0 0 24 24on each svg icon.Before:
After:
