Conversation
mzur
reviewed
Jan 29, 2026
Member
mzur
left a comment
mzur
left a comment
There was a problem hiding this comment.
I only gave the script a cursory look and added some comments. Otherwise this is beyond me. I tested it locally and it seemed to perform fine.
1. Changes the hardcoded 512 to crop_size 2. Adds check from image size before cropping 3. Avoids recreating the Sam object 4. Sets the threshold to 0.05 for image size
mzur
approved these changes
Feb 2, 2026
Member
mzur
left a comment
mzur
left a comment
There was a problem hiding this comment.
Now you set all sorts of magic numbers to 0.05 but I guess you know what you are doing 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #22
(at least partially, only optimizes the python script)
On my (admittedly very small) test dataset, the time to process a Job halves from
1h 7mto about30 mAlso improves the organisation of the script.