Adjustments for dependencies transpilation#6
Merged
OlKir merged 3 commits intoios_compatibilityfrom Oct 15, 2025
Merged
Conversation
added 2 commits
October 8, 2025 10:20
- Added lightweight stubs so the iOS build no longer needs the heavy OSM import and elevation toolchain: key placeholders live in dependencies/stubs/src/main/java/com/graphhopper/reader/osm/ OSMReader.java:20, .../GraphRestriction.java:1, .../RestrictionTagParser.java:15, and .../conditional/ConditionalOSMTagInspector.java:1. These cover the types the routing code references while keeping the implementations no-op. - Simplified GraphHopper’s elevation wiring to match the iOS workflow (external, pre-generated graphs): graphhopper/core/src/main/java/com/graphhopper/GraphHopper.java:764 now always returns ElevationProvider.NOOP, and interpolateBridgesTunnelsAndFerries is reduced to a no-op comment at graphhopper/core/src/main/java/com/graphhopper/GraphHopper.java:1194.
- Reintroduced bridge/tunnel/ferry elevation interpolation while making it configurable via graph.elevation.edge_interpolation so non-iOS builds keep the previous smoothing by default. core/src/main/java/com/
graphhopper/GraphHopper.java:99
- Added a loader-guarded setter to toggle the interpolation programmatically for tooling that prepares graphs externally. core/src/main/java/com/graphhopper/GraphHopper.java:190
- Restored the interpolation execution/logging path and gated it behind the new flag to preserve standard import behaviour. core/src/main/java/com/graphhopper/GraphHopper.java:1207
benedikt-brandtner-bikemap
pushed a commit
that referenced
this pull request
Oct 30, 2025
* navigation profile specific voiceinstruction placement * fix: hiking should have been walking * fix: try to find a mapbox profile for the graphhopper profile * Revert "fix: try to find a mapbox profile for the graphhopper profile" This reverts commit 3db1c5b. * feat: configure DistanceConfig from Profile hints too * chore: add myself (Karol Olszacki) to the contributors list * fix: create NavigationTransportMode enum and use that * fix: make sure we accept all kinds of values for wider compatibility with OSRM/Mapbox/etc * fix: DistanceConfig enhancement (#6) * fix: fold more cases into DistanceConfig, remove the new enum and allow usage of existing one * chore: update the example with gh-centric terms --------- Co-authored-by: Karol Olszacki <karol.olszacki@pl.bosch.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to transpile Java files to Obj-C, I have to make changes in GraphHopper. Initially they caused falling of tests but it should be fixed now. The changes mostly affected dependencies.
Please check commit messages for details.
Important note - those changes broke importing of OSM data functionality. In current state, this branch always expects to have a routing graph ready.