chore(modules): renumber SortOrder to remove APT/Jellyfin collision#39
Merged
Merged
Conversation
JellyfinModule and AndroidPowerToolsModule both declared SortOrder=2, so the sidebar order held only by the DisplayName alphabetical tiebreak. Renumber Jellyfin 2->3, Utilities 3->4, Cameras 4->5 so each module has a distinct ordering key (Android Devices 1, Android Power Tools 2 unchanged). Rendered sidebar/module-tile order is unchanged. Update CamerasModuleTests SortOrder assertion 4->5; CHANGELOG under Unreleased.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
JellyfinModuleandAndroidPowerToolsModuleboth declaredSortOrder = 2— the module list rendered in the intended order only by theDisplayNamealphabetical tiebreak. This gives every module a distinct key:Why
Removes a fragile collision surfaced during a documentation audit. No change to the rendered sidebar / module-tile order.
Notes
CamerasModuleTests.SortOrder_Is4->SortOrder_Is5.SortOrder = 5) will need6now that Cameras is5.