Merged
Conversation
ColmTalbot
force-pushed
the
add-github-action-testing
branch
from
69cddb7 to
1bd59ff
Compare
Collaborator
|
@ColmTalbot there are a bunch of material changes (i.e. the updated author list). Is this just because the target branch is out of date? |
ColmTalbot
force-pushed
the
add-github-action-testing
branch
from
d0b6806 to
7ba2fe1
Compare
Collaborator
Author
I just rebased |
Collaborator
Author
|
I think all the tests we need are now run here. The layout is flat and could probably be put into a more sensible flow, but I think this is enough for now. |
GregoryAshton
approved these changes
Feb 23, 2024
Collaborator
GregoryAshton
left a comment
GregoryAshton
left a comment
There was a problem hiding this comment.
I'm happy with the additions.
Collaborator
Author
|
For future reference, the squash and merge option is the merge option we want. |
ColmTalbot
added a commit
that referenced
this pull request
Feb 24, 2024
* TST: Create unit-tests.yml * TST: try explicit version * TST: Remove unnecessary setup python * TST: disable precommit tests * TST: typo * TST: add pre-commit tests * TST: try installing jupyter for pre-commit * TST: add install/import tests * TST: just install basic version * TST: typo fixes * TST: done run executable tests on windows * TST: another attempt to disable executable tests for windows * TST: remove executable tests * DOC: add documentation job * DOC: make sure to pull tags for docs job * BLD: upload docs as an artifact
ColmTalbot
added a commit
that referenced
this pull request
Sep 17, 2024
* TST: Create unit-tests.yml * TST: try explicit version * TST: Remove unnecessary setup python * TST: disable precommit tests * TST: typo * TST: add pre-commit tests * TST: try installing jupyter for pre-commit * TST: add install/import tests * TST: just install basic version * TST: typo fixes * TST: done run executable tests on windows * TST: another attempt to disable executable tests for windows * TST: remove executable tests * DOC: add documentation job * DOC: make sure to pull tags for docs job * BLD: upload docs as an artifact
46 tasks
ColmTalbot
added a commit
that referenced
this pull request
Oct 23, 2024
* BUG: fix typo in ln_i0 * TST: Add GitHub action testing (#24) * TST: Create unit-tests.yml * TST: try explicit version * TST: Remove unnecessary setup python * TST: disable precommit tests * TST: typo * TST: add pre-commit tests * TST: try installing jupyter for pre-commit * TST: add install/import tests * TST: just install basic version * TST: typo fixes * TST: done run executable tests on windows * TST: another attempt to disable executable tests for windows * TST: remove executable tests * DOC: add documentation job * DOC: make sure to pull tags for docs job * BLD: upload docs as an artifact * DEP: Update documentation and examples to reflect changes to random seed * DEP,DOC: Updated doc string to ask for np generator instance instead of legacy generator * [DEP][DOC]: updates from review, typo fix, removal of unnecessary `rng` import * [?]: Removed metadata from jupyter notebooks * Pre-commit fixes * pre-commit re-run I realised that pre-commit didn't check any files because there were no logged chagnes. So I ran pre-commit on everything using "pre-commit run --all-files". This only brought up relevant changes from myself, with the exceptions of: "bilby/bilby_mcmc/sampler.py:525:38: E226 missing whitespace around arithmetic operator" which is outside the remit of this merge request. * Adding Sean to the authors for the CI * Update bilby/core/sampler/dynesty_utils.py Co-authored-by: Colm Talbot <talbotcolm@gmail.com> * Update bilby/core/sampler/dynesty_utils.py Co-authored-by: Colm Talbot <talbotcolm@gmail.com> --------- Co-authored-by: Colm Talbot <talbotcolm@gmail.com> Co-authored-by: Colm Talbot <colm.talbot@ligo.org> Co-authored-by: Sean Hibbit <sean.hibbitt.2019@live.rhul.ac.uk> Co-authored-by: Sean Hibbitt <112953650+bretsnev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some of our CI jobs via GitHub actions.
This PR doesn't cover things that are currently on our scheduled tests, e.g., building containers, plotting tests, and example tests