BUG: ensure infinite ACT estimates are properly handled#39
Merged
mj-will merged 4 commits intobilby-dev:mainfrom Oct 29, 2024
Merged
BUG: ensure infinite ACT estimates are properly handled#39mj-will merged 4 commits intobilby-dev:mainfrom
mj-will merged 4 commits intobilby-dev:mainfrom
Conversation
cc6978f to
32f348c
Compare
GregoryAshton
approved these changes
Oct 29, 2024
Collaborator
GregoryAshton
left a comment
There was a problem hiding this comment.
Thanks @ColmTalbot this cleans things up nicely. Happy to approve.
mj-will
approved these changes
Oct 29, 2024
32f348c to
0cab5a3
Compare
JasperMartins
pushed a commit
to JasperMartins/bilby
that referenced
this pull request
Nov 1, 2024
* BUG: ensure infinite ACT estimates are properly handled * REFACTOR: promote debug to warning for poor sampling * FMT: remove excess empty line * FMT: remove excess whitespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lalit-pathak reported the following error. This happens when no points are accepted during the MCMC while using ACT-walk. This is most likely a sign of some underlying pathology in the likelihood/sampling space, but we should handle the case smoothly.
I also noticed a second case where an infinity can sneak in that will break things, if there are fewer than ten live points, the acceptance walk method will fail on current master.
I'm opening this as a test of migrating open MRs from gitlab to here. https://git.ligo.org/lscsoft/bilby/-/merge_requests/1383 is the original MR.