Remove double-backslashes from latex labels passed to matplotlib.#837
Merged
ColmTalbot merged 1 commit intobilby-dev:mainfrom Oct 25, 2024
Merged
Conversation
ColmTalbot
approved these changes
Oct 23, 2024
mj-will
reviewed
Oct 23, 2024
Collaborator
mj-will
left a comment
There was a problem hiding this comment.
Have you checked to see how this interacts with raw strings (e.g. r"$\mathcal{M}$")?
Collaborator
Author
Not 100% what you mean but afaik a variable defined as a raw string just becomes a string (with different creation rules) i.e.: |
Collaborator
Ah, I didn't know that, makes sense then :) |
mj-will
approved these changes
Oct 25, 2024
639424b to
2916635
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #836
As far as I can tell, the issue is due to a bug in bilby_pipe, but I noticed that there is already a function to remove matplotlib errors in bilby/core/result.py.
This PR simply adds a line to this function to convert "\" into "".
Either way I think this is a good thing to have, as I can't think of a scenario where having "\" in a matplotlib latex string is a good idea.