fix(ask-user): commit answers only on explicit submit#16
Merged
Conversation
Generic AskUserInline previously auto-submitted as soon as a custom input had any non-empty trimmed value, treating focus/typing as intent. That made it easy to skip past a question by tabbing into the field, and the "Got it — Continuing…" footer was unreachable in practice. Now answers commit only when the user clicks an option, presses Enter, or hits the arrow button. Removes the showCustom toggle (no longer needed) and the dead done-state footer. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
OmGuptaIND
added a commit
that referenced
this pull request
Apr 30, 2026
### Features - auto-activated skills + builtin document-creation packages (#19) ### Other - fix(attachments): persist images on disk + lazy-load chips on demand (#20) - feat(chat): collapsible turn progress + per-turn source cards (#18) - fix(artifacts): premium split panel + render docx/pdf/xlsx in files view (#17) - fix(ask-user): commit answers only on explicit submit (#16) - docs(spec): session log architecture — append-only log + multi-client channel (#15)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generic `AskUserInline` previously auto-submitted as soon as a custom input had any non-empty trimmed value, treating focus/typing as intent. That made it easy to skip past a question by tabbing through, and the trailing "Got it — Continuing…" footer was unreachable in practice.
Now answers commit only when the user clicks an option, presses Enter, or hits the arrow button. Removed the `showCustom` toggle (no longer needed) and the dead done-state footer.
Test plan
🤖 Generated with Claude Code