-
Notifications
You must be signed in to change notification settings - Fork 672
Description
Bug Name
No recvWindow Enforcement at SDK Level (Timestamp-Only Replay Window)
Attack Scenario
The send_request function adds a timestamp to signed requests but never sets a recvWindow parameter. The Binance API defaults recvWindow to 5000ms. Individual endpoint methods accept recv_window but there is no configuration-level default.
Impact
Users who need tighter replay protection windows must manually add recvWindow to every request payload. The default 5000ms window may be too wide for high-security trading operations.
Components
File: common/src/binance_common/utils.py (lines 323-331). No recvWindow in ConfigurationRestAPI.
Reproduction
- Create a signed request using the SDK.
- Inspect the request parameters.
- No recvWindow parameter is included unless manually added.
Fix
Add a recv_window parameter to ConfigurationRestAPI that is automatically included in all signed requests when set.
Details
Finding ID: SEC-04
Severity: Low
Researcher: Independent Security Researcher -- Mefai Security Team