fix: unify settings dropdowns to use custom Radix-based Select#248
Merged
fix: unify settings dropdowns to use custom Radix-based Select#248
Conversation
…lace native <select> in settings-ui.tsx with @radix-ui/react-select\nto match the app's custom dropdown design (FontSelect pattern).\n\nAll settings tabs now use consistent styled popover dropdowns with\ncheck indicators instead of OS-native select menus.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unify all settings dropdown selectors to use the app's custom Radix-based popover design instead of native OS
<select>menus.Problem
The settings page had two inconsistent dropdown styles:
FontSelect,TerminalFontSelect)<select>with system styling and right-aligned arrow (used by all other settings dropdowns)Changes
components/settings/settings-ui.tsx<select>with@radix-ui/react-selectin the sharedSelectcomponentFontSelectstyling patternAffected tabs (no code changes, automatically fixed):