Skip to content

fix: skip invalid ssh agent sockets#292

Merged
binaricat merged 1 commit intomainfrom
codex/fix-issue-290-agent-socket
Mar 9, 2026
Merged

fix: skip invalid ssh agent sockets#292
binaricat merged 1 commit intomainfrom
codex/fix-issue-290-agent-socket

Conversation

@binaricat
Copy link
Owner

Summary

  • ignore invalid Unix ssh-agent sockets before adding agent auth to the fallback chain
  • reuse the same agent availability check in the main SSH bridge
  • avoid terminal and SFTP failing early with "Failed to connect to agent" when SSH_AUTH_SOCK is stale

Testing

  • node -e "require('./electron/bridges/sshAuthHelper.cjs'); console.log('sshAuthHelper ok')"
  • node -e "require('./electron/bridges/sshBridge.cjs'); console.log('sshBridge ok')"
  • simulated a missing SSH_AUTH_SOCK and verified auth fallback no longer returns an agent

Refs #290

@binaricat binaricat merged commit 540aabb into main Mar 9, 2026
@binaricat binaricat deleted the codex/fix-issue-290-agent-socket branch March 9, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant