[codex] Show SFTP toolbar button#834
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f58b9be691
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| className={cn(buttonBase, status !== 'connected' && "opacity-50")} | ||
| aria-label={status === 'connected' ? t("terminal.toolbar.openSftp") : t("terminal.toolbar.availableAfterConnect")} | ||
| onClick={onOpenSFTP} | ||
| disabled={status !== 'connected'} |
There was a problem hiding this comment.
When session status is connecting or disconnected, this button is rendered as disabled, and the shared button styles add disabled:pointer-events-none (components/ui/button.tsx), so the TooltipTrigger can’t receive hover/focus events. That means the icon-only control loses its only visible explanation (“Available after connect”), which regresses discoverability compared with the previous overflow entry that always showed text in this state.
Useful? React with 👍 / 👎.
1 participant
Summary
Why
Issue #829 reports that the high-frequency SFTP action is hidden behind the three-dot menu. This makes a common workflow harder to discover and slower to use.
Validation
npm run lintnpm run buildnpm testCloses #829