Skip to content

[codex] Fix terminal cursor preference handling#855

Merged
binaricat merged 1 commit into
mainfrom
codex/fix-terminal-cursor-focus
Apr 28, 2026
Merged

[codex] Fix terminal cursor preference handling#855
binaricat merged 1 commit into
mainfrom
codex/fix-terminal-cursor-focus

Conversation

@binaricat
Copy link
Copy Markdown
Owner

Summary

  • keep the terminal cursor following the user's configured shape/blink preference even if terminal output tries to change it
  • restore focus to the active terminal after closing the SFTP text editor modal
  • add coverage for cursor preference handling and terminal refocus behavior

Context

Issue #833 is difficult to reproduce consistently. This change does not claim a confirmed reproduction; it adds defensive fixes based on the reported symptoms: focused terminal with non-blinking cursor, and input trouble after SFTP editing flows.

Validation

  • npm test -- components/terminal/runtime/cursorPreference.test.ts components/terminal/focusTerminalSession.test.ts
  • npm run lint
  • npm run build
  • git diff --check

@binaricat binaricat force-pushed the codex/fix-terminal-cursor-focus branch from eeda8b6 to 740c6f5 Compare April 28, 2026 09:14
@binaricat binaricat marked this pull request as ready for review April 28, 2026 09:17
@binaricat binaricat merged commit a4a5c70 into main Apr 28, 2026
@binaricat binaricat deleted the codex/fix-terminal-cursor-focus branch April 28, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant