[codex] Fix Windows mosh terminfo bundle#889
Merged
Merged
Conversation
binaricat
force-pushed
the
codex/fix-windows-mosh-terminfo
branch
from
3c15720 to
e0dc60b
Compare
This was referenced May 4, 2026
binaricat
added a commit
that referenced
this pull request
May 4, 2026
Codex review on #894 P3: the new Linux/macOS bundles drop resources/mosh/<platform-arch>/terminfo/ at fetch time, but the existing mosh ignore rules only cover the binaries and Windows DLLs. Without this rule, `npm run fetch:mosh:dev` leaves the compiled terminfo files showing up as untracked and they could be accidentally committed. Add a recursive ignore so every platform's bundle stays out of git, including the Windows side that the #889 fix already populated. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Fixes #888. The Windows mosh-client package previously included the executable and Cygwin runtime DLLs, but not the ncurses terminfo entry needed for TERM=xterm-256color. On machines without a full Cygwin installation, mosh-client exited during startup with
Terminfo database could not be found.Validation