Strip LC_* before mosh ssh handshake#905
Merged
Merged
Conversation
macOS Terminal/iTerm export LC_CTYPE=UTF-8 (a bare value, not a real locale name). The system ssh_config has SendEnv LC_*, so the value leaks to the remote and bash warns "cannot change locale (UTF-8)" on every login. mosh-server sets its own locale separately, so dropping LC_* from the spawned ssh's env is the cleanest fix. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LC_CTYPE=UTF-8(a bare value, not a real locale name). Systemssh_confighasSendEnv LC_*, so when netcatty spawns the systemsshfor mosh handshake, that value leaks to the remote and every login prints:-o "SendEnv -LC_*"first but OpenSSH processes-obefore the system config, so the-removal happens against an empty list and the systemSendEnv LC_*re-adds it.LC_*keys from the env passed to the spawnedsshchild in `startMoshSessionViaHandshake`. mosh-server already sets the locale it needs via the `LC_ALL=...` prefix.Test plan
🤖 Generated with Claude Code