Add #951: copy-host-address button to per-host statusbar#952
Merged
Conversation
) Adds a small clipboard-copy icon next to the host label / status dot in the terminal pane's statusbar. Clicking copies the host's hostname (IP or DNS name — what users called "machine IP" in #951) to the clipboard and surfaces a toast. The button only renders for non-local SSH/serial/telnet sessions — local shells don't have an addressable hostname so showing it would be confusing. Placed in the pane statusbar (not the top tab) because the statusbar is per-host: a workspace pane carries exactly one host, so the button always identifies the right address. Top tabs in a workspace can share multiple panes / hosts and would be ambiguous. Visual treatment matches the surrounding stats buttons: 10px icon, inline with the existing host label + status dot, opacity-60 → opacity-100 on hover, `title` attribute for the tooltip to match the pattern of the CPU/MEM/disk stats triggers right next to it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #951. Adds a small clipboard-copy icon to the terminal pane's statusbar (the row with the host label, status dot, and CPU/MEM/disk stats). Clicking it copies the host's hostname / IP and shows a toast.
The button only renders for non-local sessions (SSH/serial/telnet with a real address). Local shells don't have an addressable hostname so showing it would be confusing.
Why statusbar, not top tab
The top tab can be shared across multiple panes in a workspace (mixed hosts), so a button there would be ambiguous about "which host's IP". The per-host statusbar carries exactly one host, so the action is unambiguous.
Visual
Matches the surrounding pattern: 10px icon, inline with the existing host label + status dot, opacity-60 → opacity-100 on hover,
titleattribute for the tooltip (consistent with the CPU/MEM/disk stat triggers right next to it).Test plan
npm test— 788 pass / 0 failnpm run lint— cleannpm run build— cleanCloses #951.