feat(sftp): add drive switcher dropdown for local Windows panes#953
Conversation
On Windows, the SFTP breadcrumb's first segment (drive letter) now shows a dropdown to switch between available drives. This makes it easy to navigate across drives without manually editing the path. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e38963c37f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for (let i = 65; i <= 90; i++) { | ||
| const letter = String.fromCharCode(i); | ||
| try { | ||
| fs.accessSync(letter + ":\\"); |
There was a problem hiding this comment.
Avoid using fs.accessSync in listDrives() because this handler runs in Electron’s main process and is invoked from the renderer when opening the breadcrumb dropdown. The current loop performs up to 26 synchronous filesystem checks, which can stall the main process and make the UI feel frozen (especially when probing slow/unavailable removable or mapped drives). Switching this path to non-blocking I/O (or another async drive-enumeration approach) prevents UI hitching during drive menu open.
Useful? React with 👍 / 👎.
fs.accessSync in the listDrives IPC handler could stall the Electron main process for seconds per disconnected mapped drive or empty optical drive. Use fs.promises.access with Promise.allSettled so the 26 probes run in parallel without blocking the event loop. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Good job！ |
3 participants
Summary
listDrivesIPC bridge usingwmic logicaldiskto enumerate available drivesTest plan
🤖 Generated with Claude Code