This repository was archived by the owner on Feb 22, 2024. It is now read-only.
Gokula/fix bot build tag #2676
Merged
Gokula/fix bot build tag #2676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev to beta
beta to master
dev to beta
dev to beta
dev to beta
dev to beta
beta to master
dev to beta
beta to master
dev to beta
beta to master
dev to beta
dev to beta
dev to beta
beta to master
dev to beta
beta to master
dev to beta
beta to master
dev to beta
beta to master
.circleci/config.yml
Outdated
| docker build -t ${DOCKHUB_ORGANISATION}/binary-static-bot:${build_tag} -t ${DOCKHUB_ORGANISATION}/binary-static-bot:latest . | ||
| build_latest="latest" | ||
| [ "<< parameters.target >>" == "beta" ] && build_tag="beta-${CIRCLE_SHA1}" && build_latest="beta-latest" | ||
| docker build -t ${DOCKHUB_ORGANISATION}/binary-static-bot:${build_tag} -t ${DOCKHUB_ORGANISATION}/binary-static-bot:build_latest . |
Contributor
There was a problem hiding this comment.
It must change to this:
docker build -t ${DOCKHUB_ORGANISATION}/binary-static-bot:${build_tag} -t ${DOCKHUB_ORGANISATION}/binary-static-bot:${build_latest} .
.circleci/config.yml
Outdated
| echo $DOCKERHUB_PASSWORD | docker login -u $DOCKERHUB_USERNAME --password-stdin | ||
| docker push ${DOCKHUB_ORGANISATION}/binary-static-bot:${build_tag} | ||
| docker push ${DOCKHUB_ORGANISATION}/binary-static-bot:latest | ||
| docker push ${DOCKHUB_ORGANISATION}/binary-static-bot:build_latest |
Contributor
There was a problem hiding this comment.
It's better to remove tag in docker push command or change build_latest as a variable
docker push ${DOCKHUB_ORGANISATION}/binary-static-bot
or
docker push ${DOCKHUB_ORGANISATION}/binary-static-bot:${build_latest}
.circleci/config.yml
Outdated
Comment on lines
97
to
99
| build_tag="${CIRCLE_SHA1}" | ||
| [ "<< parameters.target >>" == "beta" ] && build_tag="beta-${CIRCLE_SHA1}" | ||
| docker build -t ${DOCKHUB_ORGANISATION}/binary-static-bot:${build_tag} -t ${DOCKHUB_ORGANISATION}/binary-static-bot:latest . | ||
| build_latest="latest" | ||
| [ "<< parameters.target >>" == "beta" ] && build_tag="beta-${CIRCLE_SHA1}" && build_latest="beta-latest" |
Contributor
There was a problem hiding this comment.
also build_latest should be a parameter that would either have a value "beta-latest" or "latest" from workflow. build_tag value can be either CIRCLE_SHA1 or CIRCLE_TAG which should be set from workflow
.circleci/config.yml
Outdated
Comment on lines
129
to
130
| build_tag="${CIRCLE_SHA1}" | ||
| deployment_target="bot-binary-com" |
Contributor
There was a problem hiding this comment.
again if you declare build_tag and deployment_target as a parameter and set the value from workflow based on staging and production things would be much easier.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2