This repository was archived by the owner on Feb 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 229
Hubert / e-mail input wouldn't show error after making valid e-mail address invalid again. #6684
Merged
mamali-fs
merged 20 commits into
binary-com:master
from
hubert-deriv:no_error_message_email
Sep 7, 2021
Merged
Hubert / e-mail input wouldn't show error after making valid e-mail address invalid again. #6684
mamali-fs
merged 20 commits into
binary-com:master
from
hubert-deriv:no_error_message_email
Sep 7, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/deriv/binary-static/42LRkbQAxc1DfwdUq1CQgMpCkZGK |
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
akmal-deriv
reviewed
Jul 21, 2021
akmal-deriv
reviewed
Jul 29, 2021
akmal-deriv
reviewed
Jul 29, 2021
akmal-deriv
previously approved these changes
Aug 2, 2021
akmal-deriv
previously approved these changes
Aug 2, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.








When the user fills in a valid e-mail, the error message will disappear, indicating the validity of the e-mail. Although, when the user removes some characters again, or adds invalid characters, the error wouldn't show up again.