Mahdiyeh/ Fix: guide on 4th step

[mahdiyeh-deriv]

No description provided.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/binary-static/7ougGqkVSGfMzBNc9oTkqhqErxfF
✅ Preview: https://binary-static-git-fork-mahdiyeh-fs-fixguide.binary.sx

[github-actions]

A production App ID was automatically generated for this PR. (log)

• PR: Mahdiyeh/ Fix: guide on 4th step #6753
• URLs:
  • w/ App ID + Server: https://binary-static-git-fork-mahdiyeh-fs-fixguide.binary.sx/en/logged_inws.html?qa_server=frontend.binaryws.com&app_id=29844
  • Original: https://binary-static-git-fork-mahdiyeh-fs-fixguide.binary.sx/en/logged_inws.html
• App ID: 29844

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/binary-static/pull/6753](https://github.com/binary-com/binary-static/pull/6753)
- **URLs**:
    - **w/ App ID + Server**: https://binary-static-git-fork-mahdiyeh-fs-fixguide.binary.sx/en/logged_inws.html?qa_server=frontend.binaryws.com&app_id=29844
    - **Original**: https://binary-static-git-fork-mahdiyeh-fs-fixguide.binary.sx/en/logged_inws.html
- **App ID**: `29844`

[akmal-deriv]

Can we use snake_case for these constants? contract_list and close_confirmation

[mahdiyeh-deriv]

since guideBtnID is in the camelCase format, i keep it the same

[akmal-deriv]

I think it's the old practice which we don't use anymore. Maybe you can also change guideBtnID to guide_btn_id?

[akmal-deriv]

My suggestion would be to make all three consistent like guide_btn_id, contract_list_id, and close_confirmation_id. Do you think this would be better?

[mahdiyeh-deriv]

yeah, right, will handle that, thanks

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
9.0% Duplication