This repository was archived by the owner on Feb 22, 2024. It is now read-only.
Mohsen / fixed duplicate idv notification error #7154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
co-authored : <mitra@deriv.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
Comment on lines
1223
to
1230
| const showNoticeMessage = (text) => { | ||
| const reload_function = () => { | ||
| window.location.reload(); | ||
| }; | ||
|
|
||
| const button_reload = $('<button/>' , { class: 'button container' , type: 'button' , text: 'Try Again' }).on('click' , reload_function).css({ 'margin': '0 auto' ,'display': 'block' }); | ||
| $('#content').empty().html($('<div/>', { class: 'container' }).append($('<p/>', { class: 'notice-msg center-text', text })).append(button_reload)); | ||
| }; |
Contributor
There was a problem hiding this comment.
Suggested change
| const showNoticeMessage = (text) => { | |
| const reload_function = () => { | |
| window.location.reload(); | |
| }; | |
| const button_reload = $('<button/>' , { class: 'button container' , type: 'button' , text: 'Try Again' }).on('click' , reload_function).css({ 'margin': '0 auto' ,'display': 'block' }); | |
| $('#content').empty().html($('<div/>', { class: 'container' }).append($('<p/>', { class: 'notice-msg center-text', text })).append(button_reload)); | |
| }; | |
| const showNoticeMessage = (text) => { | |
| const reload_function = () => { | |
| window.location.reload(); | |
| }; | |
| const button_reload = $('<button/>' , { class: 'button container' , type: 'button' , text: 'Try Again' }).on('click' , reload_function).css({ 'margin': '0 auto' ,'display': 'block' }); | |
| $('#content').empty().html($('<div/>', { class: 'container' }).append($('<p/>', { class: 'notice-msg center-text', text })).append(button_reload)); | |
| }; |
I think it's best that we move this to the template jsx and attach an id with a default of hidden. That's how things are done in this project. Show/Hide 😅 we don't usually construct markup from JQuery like this
Contributor
Author
There was a problem hiding this comment.
Thanks @yashim-deriv , I applied the suggested changes, I was not aware of the ways of binary-com project.
|
Kudos, SonarCloud Quality Gate passed!
|
yashim-deriv
previously approved these changes
Jun 30, 2022
- updated node versions in package.json, circlci config and crowdin github action
…hio-rework/binary-static into fix-dupilcate-idv-notification-error
habib-deriv
approved these changes
Aug 17, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
co-authored : mitra@deriv.com