Skip to content
This repository was archived by the owner on Feb 22, 2024. It is now read-only.

Maryia/task_push_labuan_bvi_vanuatu #7164

Merged
matin-deriv merged 9 commits into from
Aug 2, 2022
Merged

Maryia/task_push_labuan_bvi_vanuatu #7164

matin-deriv merged 9 commits into from
Aug 2, 2022

Conversation

@maryia-deriv
Copy link
Contributor

@maryia-deriv maryia-deriv commented Jul 20, 2022 •
edited
Loading

Binary updates

  • removed Add region button (under real synthetic account)
  • added 'Go to Deriv' pop-up & banner
  • flow for new and existing clients
  • showing existing STP even if missing from landing_company response
  • refactoring

@vercel
Copy link

vercel bot commented Jul 20, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
binary-static ✅ Ready (Inspect) Visit Preview Sep 1, 2022 at 2:46PM (UTC)

@github-actions
Copy link

github-actions bot commented Jul 20, 2022 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/binary-static/pull/7164](https://github.com/binary-com/binary-static/pull/7164)
- **URLs**:
    - **w/ App ID + Server**: https://binary-static-git-fork-maryia-binary-taskpushlabuanbvivanuatu.binary.sx/en/logged_inws.html?qa_server=frontend.binaryws.com&app_id=31308
    - **Original**: https://binary-static-git-fork-maryia-binary-taskpushlabuanbvivanuatu.binary.sx/en/logged_inws.html
- **App ID**: `31308`

@maryia-deriv maryia-deriv marked this pull request as ready for review July 21, 2022 14:08
@maryia-deriv maryia-deriv changed the title Maryia/task_push_labuan_bvi_vanuatu Maryia/Binary_task_push_labuan_bvi_vanuatu Jul 21, 2022
@maryia-deriv maryia-deriv changed the title Maryia/Binary_task_push_labuan_bvi_vanuatu Maryia/task_push_labuan_bvi_vanuatu Jul 21, 2022
maryia-deriv
maryia-deriv commented Jul 22, 2022
View reviewed changes
src/javascript/app/pages/user/metatrader/metatrader.ui.js
const region = server_info && server_info.geolocation.region;
const sequence = server_info && server_info.geolocation.sequence;
const label_text = server_info ? sequence > 1 ? `${region} ${sequence}` : region : getAccountsInfo(acc_type).info.display_server;
const region_to_show = sequence > 1 ? `${region} ${sequence}` : region;
Copy link
Contributor Author

@maryia-deriv maryia-deriv Jul 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactoring to eliminate Eslint warnings

matin-deriv
matin-deriv previously approved these changes Jul 24, 2022
View reviewed changes
Copy link
Contributor

@matin-deriv matin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@matin-deriv matin-deriv merged commit 67f9cef into binary-com:master Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@matin-deriv matin-deriv matin-deriv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maryia-deriv @matin-deriv