This repository was archived by the owner on Feb 22, 2024. It is now read-only.
Suisin/scam message warning for brazil binary #7229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sin/scam_message_warning_for_brazil_binary
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…sin/scam_message_warning_for_brazil_binary
…b.com:suisin-deriv/binary-static into suisin/scam_message_warning_for_brazil_binary
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
src/javascript/app/base/page.js
Outdated
| }, 1000); | ||
| RealityCheck.onLoad(); | ||
| Menu.init(); | ||
| const is_at_brazil = State.getResponse('website_status.clients_country') === 'br'; |
Contributor
There was a problem hiding this comment.
shouldn't it be like this:
const is_at_brazil = (Client.get('residence') === 'br' ||State.getResponse('website_status.clients_country') === 'br');
also better to name it is_br_client
Contributor
Author
There was a problem hiding this comment.
I just wanted client which they access their account in brazil.
|
Deployment failed with the following error: |
matin-deriv
reviewed
Sep 19, 2022
Comment on lines
19
to
20
| const is_message_read = localStorage.getItem('read_scam_message') || false; | ||
| const is_new_account = localStorage.getItem('new_user_account') || false; |
Contributor
There was a problem hiding this comment.
Suggested change
| const is_message_read = localStorage.getItem('read_scam_message') || false; | |
| const is_new_account = localStorage.getItem('new_user_account') || false; | |
| const is_message_read = !!localStorage.getItem('read_scam_message'); | |
| const is_new_account = !!localStorage.getItem('new_user_account'); |
Doing !! will coerce null values to false
mahdiyeh-deriv
previously approved these changes
Sep 19, 2022
matin-deriv
previously approved these changes
Sep 19, 2022
yashim-deriv
previously approved these changes
Sep 20, 2022
…b.com:suisin-deriv/binary-static into suisin/scam_message_warning_for_brazil_binary
suisin-deriv
dismissed stale reviews from yashim-deriv, matin-deriv, and mahdiyeh-deriv
via
115a245
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.