This repository was archived by the owner on May 13, 2024. It is now read-only.
feat: added testcase and popup #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
==========================================
+ Coverage 96.95% 96.98% +0.02%
==========================================
Files 108 109 +1
Lines 1543 1558 +15
Branches 196 198 +2
==========================================
+ Hits 1496 1511 +15
Misses 5 5
Partials 42 42
|
…om:utkarsha-deriv/deriv-api-docs into utkarsha/display-popup-upon-token-creation update branch
mohsen-deriv
suggested changes
Jun 16, 2023
src/features/dashboard/components/Dialogs/TokenCreationDialogSuccess/index.tsx
Show resolved
Hide resolved
mohsen-deriv
previously approved these changes
Jun 16, 2023
matin-deriv
previously approved these changes
Jun 21, 2023
…also testcases written
Contributor
hubert-deriv
left a comment
hubert-deriv
left a comment
There was a problem hiding this comment.
Please resolve the conflicts so that I can merge
mohsen-deriv
previously approved these changes
Jul 3, 2023
sanjam-deriv
previously approved these changes
Jul 4, 2023
hubert-deriv
suggested changes
Jul 20, 2023
| @@ -1,5 +1,5 @@ | |||
| import React from 'react'; | |||
| import { cleanup, render, screen, within } from '@site/src/test-utils'; | |||
| import { cleanup, fireEvent, render, screen, within } from '@site/src/test-utils'; | |||
Contributor
There was a problem hiding this comment.
I believe we are not using fireEvent right? I think we can remove this import then.
| }); | ||
| createToken(name, selectedTokenScope); | ||
| setFormIsCleared(true); | ||
| setToggleModal(!is_toggle); |
Contributor
There was a problem hiding this comment.
I think setToggleModal(prev => !prev) is a nicer way of handling it. If setting your state is dependent on your previous state, you should use this prev (or prevState) method.
hubert-deriv
previously approved these changes
Jul 20, 2023
matin-deriv
previously approved these changes
Jul 21, 2023
utkarsha-deriv
dismissed stale reviews from matin-deriv and hubert-deriv
via
39ac8e4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.