Refactor/auto compile #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
review-deriv
left a comment
review-deriv
left a comment
There was a problem hiding this comment.
PR description is too short. You can use this format:
# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.
# Cards
* https://clickup.com/12345
* https://clickup.com/12346
review-deriv
left a comment
review-deriv
left a comment
There was a problem hiding this comment.
PR description is too short. You can use this format:
# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.
# Cards
* https://clickup.com/12345
* https://clickup.com/12346
There was a problem hiding this comment.
I think rebuild deriv/perl , debian-pg, based on the new perl is not incluced in this task
Contributor
Author
There was a problem hiding this comment.
I removed them from card description. we can do that in other cards.
chylli-deriv
commented
Mar 19, 2024
README.md
Outdated
| make | ||
| make install | ||
| ```bash | ||
| VERSION=5.26.1 ./rebuild.sh |
Contributor
There was a problem hiding this comment.
should we reference 5.26 here?
chylli-deriv
commented
Mar 25, 2024
lim-deriv
reviewed
Mar 25, 2024
chylli-deriv
force-pushed
the
refactor/auto-compile
branch
from
b55ab7a to
7c2f241
Compare
Co-authored-by: kathleen-deriv <122329285+lim-deriv@users.noreply.github.com>
chylli-deriv
force-pushed
the
refactor/auto-compile
branch
from
7c2f241 to
7c554df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile perl with CI system