This repository was archived by the owner on Feb 22, 2024. It is now read-only.
amam/upgrade_dependencies_security_patch #1404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cakasuma
commented
Feb 26, 2019
cakasuma
commented
- remove grunt gitinfo (not maintained and lodash dependencies security hasnt been patched)
- upgrade grunt css min to upgrade security dependencies
- install githash and register grunt task for deploy branch on githash
OskarAhl
reviewed
Feb 27, 2019
| gitinfo: { | ||
| local: { branch: { current: { SHA: "", name: "", currentUser: "", } } }, | ||
| remote: { origin: { url: "" } } | ||
| githash: { |
Contributor
There was a problem hiding this comment.
Does this task do anything?
Contributor
Author
There was a problem hiding this comment.
githash/gitinfo used to retrieve information about the current git status such as branch, hash, etc. it is used when we deploy to our local branch. this task used in grunt deploy-branch
to use the task we have to configure in the initConfig and register the task in the grunt.registerTask
OskarAhl
approved these changes
Feb 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.