This repository was archived by the owner on Feb 22, 2024. It is now read-only.
khalid/fixed dragging issues #1468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
khalidibrahimio
commented
May 27, 2019
khalidibrahimio
commented
- Dragging containment disabled after a window is maximiszd and then restored
- Dragging limit is set to disable dragging horizontally outside the window
cakasuma
suggested changes
May 27, 2019
src/windows/tracker.es6
Outdated
| save_states(); | ||
| }); | ||
| blankWindow.on('dialogextendrestore',() => { | ||
| dialog.draggable({ |
src/windows/windows.es6
Outdated
|
|
||
| if (top < 0) { | ||
| dialog.animate({ top: '0px' }, 300, dialog.trigger.bind(dialog, 'animated')); | ||
| if (top < 106) { |
Contributor
There was a problem hiding this comment.
can we get nav height instead of hardcoded height value
cakasuma
approved these changes
May 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.