This repository was archived by the owner on Feb 22, 2024. It is now read-only.
shudarshon.chaks/enabled artifact and artifact checksum upload steps in circleci #1518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shudarshon-deriv
changed the title
4p00rv
reviewed
Feb 5, 2020
.circleci/config.yml
Outdated
| - npm_install | ||
| - build | ||
| - compress | ||
| - upload_artifact |
Contributor
There was a problem hiding this comment.
Suggested change
| - upload_artifact | |
| # Uploading the built code to s3 to create a backup of key services separate from Kubernetes deployment. | |
| - upload_artifact |
Adding a comment to let the future developers know of the reason for this.
4p00rv
reviewed
Feb 5, 2020
deploy/cron.sh
Outdated
| @@ -0,0 +1,26 @@ | |||
| #!/usr/bin/env bash | |||
Contributor
There was a problem hiding this comment.
@shudarshon-binary I don't think we need this file in the repo.
aminmarashi
reviewed
Feb 14, 2020
| name: "Compress" | ||
| command: | | ||
| pushd dist/compressed/ | ||
| tar -cvf artifact.tar * |
There was a problem hiding this comment.
Why don't we compress the tar file? it needs z for zip.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.