Skip to content
This repository was archived by the owner on Feb 22, 2024. It is now read-only.

Refactor circleci config #1524

Merged
merged 74 commits into from
Apr 10, 2020
Merged

Refactor circleci config #1524

merged 74 commits into from
Apr 10, 2020

Conversation

@afshin-paydar
Copy link
Contributor

@afshin-paydar afshin-paydar commented Apr 6, 2020

No description provided.

ashkanx and others added 30 commits September 17, 2019 09:09
@ashkanx
Merge pull request #1492 from binary-com/development
b77c34c 
V2019917_0
@oskar-binary
Merge pull request #1496 from binary-com/development
5c36fa9 
V2019917_1
@oskar-binary
Merge pull request #1500 from binary-com/development
a253ad1 
V20191104_0
@oskar-binary
Revert "V20191104_0"
45c5430
@oskar-binary
Merge pull request #1501 from binary-com/revert-1500-development
978123a 
Revert "V20191104_0"
@oskar-binary
Revert "Revert "V20191104_0""
0b33588
@oskar-binary
Merge pull request #1502 from binary-com/revert-1501-revert-1500-deve…
49952c7 
…lopment

Revert "Revert "V20191104_0""
@4p00rv @jy-deriv
move build to circleci (#1505)
26eae84 
* move build to circleci

* fix circleci config

* change base image to node

* try node 12.13.0 image

* try circleci node image

* update build command

* update docker image name

* rm travi
@mustofa-binary
add circleci and config to theirs
72293a5
@oskar-binary
Merge pull request #1517 from mustofa-binary/development
ce18b0b 
V20200115_0
@shudarshon-deriv
edit: disabled docker build and k8s deploy
7e67e9e
@shudarshon-deriv
edit: testing artifact storing configuration
67b1331
@shudarshon-deriv
edit: edited project build command
a1382b8
@shudarshon-deriv
edit: edited artifact path
b55291b
@shudarshon-deriv
using artifact path as compressed static content
57c200e
@shudarshon-deriv
edit: added artifact compression step
083d00b
@shudarshon-deriv
edit: added artifact moving step
e67bc1f
@shudarshon-deriv
edit: edited artifact name and desitnation configuration
eddee1c
@shudarshon-deriv
add: added artifact upload to s3 step
2bd2fd0
@shudarshon-deriv
edit: added circle ci project name in s3 upload url
7fe1283
@shudarshon-deriv
test: testing environment variable integration
c5df571
@shudarshon-deriv
testing circle ci variable
63ac8cb
@shudarshon-deriv
edit: edited orb alias and removed unwanted artifact configuration
ed15ef4
@shudarshon-deriv
add: added commit-id/checksum as an added information regarding artficat
f7e514c
@shudarshon-deriv
edit: testing circle ci config with singel step artifact upload
dab9041
@shudarshon-deriv
fix: fix s3 copy error in pipeline script
5cddd6b
@shudarshon-deriv
disabled checksum calculation and enabled commit id as artifact id
e396bea
@shudarshon-deriv
edit: enabled commit id upload as a jobs step
a301d60
@shudarshon-deriv
edit: uploading checksum instead of commit id
3baa4fa
@shudarshon-deriv
add: add cron script for deployment
29e49d7
4p00rv
4p00rv reviewed Apr 7, 2020
View reviewed changes
Dockerfile
@@ -1,3 +1,3 @@
FROM nginx:alpine
COPY ./dist/compressed /usr/share/nginx/html/beta
Copy link
Contributor

@4p00rv 4p00rv Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to dynamic based on type of release

Copy link
Contributor Author

@afshin-paydar afshin-paydar Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dockerfile changed to dynamically load nginx location.

@msamprz
Copy link
Contributor

msamprz commented Apr 8, 2020

The npm_install job runs npm install which reads from package.json so the cache key check is set up correctly, however, I think it would be better if we switch to use npm ci which reads from package-lock.json. npm install updates packages to the latest "wanted" version instead of the exact version that was tested, which might not be good practice for a staging/production release config. Otherwise, LGTM.

@4p00rv 4p00rv merged commit 3e014d1 into binary-com:development Apr 10, 2020
4p00rv added a commit that referenced this pull request Apr 10, 2020
@4p00rv
Revert "Refactor circleci config (#1524)"
7bc1dfa 
This reverts commit 3e014d1.
@4p00rv 4p00rv mentioned this pull request Apr 10, 2020
Merged
4p00rv added a commit that referenced this pull request Apr 10, 2020
@4p00rv
Revert "Refactor circleci config (#1524)" (#1525)
9dbfb89 
This reverts commit 3e014d1.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@4p00rv 4p00rv 4p00rv approved these changes

@msamprz msamprz msamprz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@afshin-paydar @msamprz @4p00rv @ashkanx @oskar-binary @mustofa-binary @shudarshon-deriv @Mahboobeh-binary