Remove hardcoded local filesystem path#75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the last "important" case of
/home/wtwhiteappearing in a script.Remaining local filesystem paths
coverage-debug/. Not included incross-build-diff-test.zipas it's not insidefind-diff-classes. Safe to ignore..classfiles belowcompile/. Can be ignored since they're deleted bymake clean-compile.run-mvn/gaoss/com/github/oshi/oshi-core/6.4.0/TEST-oshi.driver.windows.registry.HkeyPerformanceDataUtil_ESTest.xml(these are obsolete and can be ignored)..._ESTest_scaffolding.javasource files:Testing
Fully tested on a fresh machine, using the instructions in the README to compile and run already-generated tests, including un-
exporting$DISPLAY(from the Common Issues). Took ~2 hours to produce identical results to the paper: