Skip to content

Compile tests too but don't run them #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wtwhite merged 2 commits into from
Nov 28, 2023
Merged

Compile tests too but don't run them #52

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9269c93
Compile tests too but don't run them
wtwhite Nov 28, 2023
63640dd
Save <projectname>-tests.jar as well if it exists
wtwhite Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion docker-build-project.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ echo "building project"
# "docker exec -it" fails if stdin is not a terminal, e.g., when running in the background
# "umask 0" to make downloaded artifacts, which will be saved in the shared cache as root, can be modified/deleted from the host. "exec" to keep mvn as pid 1, important for docker signal handling.
[ "$STOP_BEFORE" = "mvn" ] && exit
docker exec -t $DOCKER_CONTAINER sh -c "umask 0; exec ${MAVEN_CONTAINER}/bin/mvn -Dmaven.repo.local=${MAVEN_CACHE_CONTAINER} -Drat.skip=true -Dmaven.test.skip=true -Dmaven.javadoc.skip=true -Dcyclonedx.skip=true clean package" | sed $'s,\x1b\\[[0-9;]*[a-zA-Z],,g' | tee ${TMP_LOG}
docker exec -t $DOCKER_CONTAINER sh -c "umask 0; exec ${MAVEN_CONTAINER}/bin/mvn -Dmaven.repo.local=${MAVEN_CACHE_CONTAINER} -Drat.skip=true -DskipTests -Dmaven.javadoc.skip=true -Dcyclonedx.skip=true clean package" | sed $'s,\x1b\\[[0-9;]*[a-zA-Z],,g' | tee ${TMP_LOG}
# Some projects make files with restricted perms even if umask 0 is in force, and if --userns-remap is in force we otherwise wouldn't be able to delete them on the host afterwards.
# Ignore "permission denied" on the top-level dir as it's owned by the host uid -- easier than trying to use wildcards to correctly get dotfiles and dotdirs.
[ "$STOP_BEFORE" = "chmod" ] && exit
Expand All @@ -127,6 +127,15 @@ echo ""
if test -f "${WORKTREE_HOST}/target/${JAR_NAME}"; then
echo "SUCCESS! - copying /target/${JAR_NAME} into ${RESULT_FOLDER}"
cp ${WORKTREE_HOST}/target/${JAR_NAME} ${RESULT_FOLDER}

# At least some projects also create a jar containing compiled tests -- get that too.
TEST_JAR_PATH="${WORKTREE_HOST}/target/${JAR_NAME%%.jar}-tests.jar"
if test -f $TEST_JAR_PATH; then
echo "Found tests jar $TEST_JAR_PATH, copying that also."
cp "$TEST_JAR_PATH" "$RESULT_FOLDER"
fi

# Gather some additional metadata
( cd "${WORKTREE_HOST}" && find target/generated-sources | sort ) > "${RESULT_FOLDER}/${JAR_NAME}.generated-sources" # Failure here creates a 0-length file, which is fine
( cd "${WORKTREE_HOST}" && find target -type f -name '*.class' | xargs "$DETECT_BYTECODE_FEATURES" | sort ) > "${RESULT_FOLDER}/${JAR_NAME}.bytecode-features"
else
Expand Down