Conversation
Previous front-end was based on delayed execution for runtime speculation; this preprocesses beforehand. It's much more limited (can't speculate commands with dynamic arguments), but can achieve better speedups.
Bioinfo has a correctness bug fixed by using if statements in the preprocessing and captk did not have all data downloaded
I moved these to the paper repo.
This reverts commit 5f05807. There is no point in testing python hS in CI because it is a prototype that will likely not be extended without rewriting.
Member
|
We certainly want to merge it as long as the changes don't affect original execution and tests. @gliargovas and @SleepyMug: could you take a look after OSDI and merge if things look good? No rush to do it now! |
Member
|
@SleepyMug and @gliargovas: could you review and merge this PR if things look good? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here’s the complete Python front-end for hS. Do we want to merge this in rather than keep it on a branch?