Conversation
angelhof
reviewed
Mar 22, 2023
| ## Check if the two exit codes are both success or both error | ||
| { [ $test_bash_ec -eq 0 ] && [ $test_pash_ec -eq 0 ]; } || { [ $test_bash_ec -ne 0 ] && [ $test_pash_ec -ne 0 ]; } | ||
| test_ec=$? | ||
| # ## Check if the two exit codes are both success or both error |
Member
There was a problem hiding this comment.
Add a TODO that we comment this out until we actually fix exit code handling in the system
| # run_test test4 | ||
| run_test test4 | ||
| cleanup | ||
| # TODO: Fails at the moment, uncomment when fixed |
Collaborator
Author
There was a problem hiding this comment.
Test 5 used to fail, now it passes 😃
Collaborator
Author
|
@angelhof ready for review, unless we want to also implement W-W dependency optimization here. |
angelhof
approved these changes
Mar 24, 2023
Member
angelhof
left a comment
angelhof
left a comment
There was a problem hiding this comment.
Looks good, we can actually deal wtih the WW optimization here (since you are already commiting sandboxes in order I guess that we just need to not consider W - W conflict a dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This WIP will solve the backward dependency rollback issue.