Merged
Conversation
Collaborator
Author
|
@angelhof Tests pass, maybe we can merge here to add stdout printing and directory committing, and create a separate branch for the tracing enhancements we discussed in today's meeting. |
angelhof
reviewed
Mar 29, 2023
| @@ -67,16 +105,30 @@ def get_lauch_name(trace_item): | |||
|
|
|||
| ## Parse the trace object and gather rw sets for this command | |||
| def parse_and_gather_cmd_rw_sets(trace_object) -> Tuple[set, set]: | |||
Member
There was a problem hiding this comment.
I think this refactoring goes toward the right direction but stops a step early :) It would make more sense to break the parse_and_gather to a parse and a gather. The parse takes a trace object and returns a dictionary of path refs (from their id r1, r2 to the actual path ref. Then, the gather_rw_sets takes this dictonary and traverses it completely to find all reads and writes of a command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.