Skip to content

33 improve logging and add a post execution summarygraphical representation of the scheduled script#34

Merged
gliargovas merged 16 commits intomainfrom
33-improve-logging-and-add-a-post-execution-summarygraphical-representation-of-the-scheduled-script
Apr 24, 2023
Merged

33 improve logging and add a post execution summarygraphical representation of the scheduled script#34
gliargovas merged 16 commits intomainfrom
33-improve-logging-and-add-a-post-execution-summarygraphical-representation-of-the-scheduled-script

Conversation

@gliargovas
Copy link
Copy Markdown
Collaborator

@gliargovas gliargovas commented Apr 20, 2023

No description provided.

@gliargovas gliargovas self-assigned this Apr 20, 2023
@gliargovas gliargovas linked an issue Apr 20, 2023 that may be closed by this pull request
Improve logging and add a post-execution summary/graphical representation of the scheduled script #33
Closed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2023

OS:ubuntu-22.04
Thu Apr 20 16:49:13 UTC 2023
Summary: 21/21 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2023

OS:ubuntu-22.04
Thu Apr 20 16:49:59 UTC 2023
Summary: 21/21 tests passed.

angelhof
angelhof requested changes Apr 21, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@angelhof angelhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work in general :) Could you add a flag to enable these logs and also add instructions on how to generate the plots in README (or in the flag help text?). Then we can merge it!

Comment thread pash-spec.sh Outdated
## Initialize the scheduler-server
export PASH_SPEC_SCHEDULER_SOCKET="${PASH_SPEC_TMP_PREFIX}/scheduler_socket"

export LOG_DIR="$PASH_SPEC_TOP/logs"
Copy link
Copy Markdown
Member

@angelhof angelhof Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right directory to save logs. I would save them under PASH_SPEC_TMP_PREFIX/tracing_logs or something like that, and only if the debug flag is set (or if some other flag that enables these logs is set).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2023

OS:ubuntu-22.04
Fri Apr 21 22:48:15 UTC 2023
Summary: 0/21 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 24, 2023

OS:ubuntu-22.04
Mon Apr 24 22:05:18 UTC 2023
Summary: 16/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 24, 2023

OS:ubuntu-22.04
Mon Apr 24 23:53:10 UTC 2023
Summary: 21/22 tests passed.

@gliargovas gliargovas merged commit ba7209f into main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@angelhof angelhof angelhof requested changes

Assignees

@gliargovas gliargovas

Labels

work in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve logging and add a post-execution summary/graphical representation of the scheduled script

2 participants

@gliargovas @angelhof