Skip to content

Enviroment export tracing issue fix#37

Merged
angelhof merged 21 commits intomainfrom
enviroment-export-tracing-issue-fix
May 3, 2023
Merged

Enviroment export tracing issue fix#37
angelhof merged 21 commits intomainfrom
enviroment-export-tracing-issue-fix

Conversation

@gliargovas
Copy link
Copy Markdown
Collaborator

No description provided.

@gliargovas gliargovas self-assigned this Apr 27, 2023
@github-actions
Copy link
Copy Markdown

OS:ubuntu-22.04
Thu Apr 27 23:21:00 UTC 2023
Summary: 16/22 tests passed.

@github-actions
Copy link
Copy Markdown

OS:ubuntu-22.04
Thu Apr 27 23:21:49 UTC 2023
Summary: 17/22 tests passed.

@github-actions
Copy link
Copy Markdown

OS:ubuntu-22.04
Fri Apr 28 14:31:32 UTC 2023
Summary: 3/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2023

OS:ubuntu-22.04
Wed May 3 15:52:09 UTC 2023
Summary: 3/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2023

OS:ubuntu-22.04
Wed May 3 16:00:43 UTC 2023
Summary: 3/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2023

OS:ubuntu-22.04
Wed May 3 16:32:52 UTC 2023
Summary: 0/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2023

OS:ubuntu-22.04
Wed May 3 16:43:14 UTC 2023
Summary: 0/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2023

OS:ubuntu-22.04
Wed May 3 16:47:54 UTC 2023
Summary: 3/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2023

OS:ubuntu-22.04
Wed May 3 16:56:41 UTC 2023
Summary: 3/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2023

OS:ubuntu-22.04
Wed May 3 17:21:35 UTC 2023
Summary: 20/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2023

OS:ubuntu-20.04
Wed May 3 17:32:26 UTC 2023
Summary: 18/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2023

OS:ubuntu-20.04
Wed May 3 18:33:48 UTC 2023
Summary: 3/22 tests passed.

Comment thread parallel-orch/trace.py
## so we never want to keep /dev/tty in the read-write sets of any node.
## We take care of writes to stdout and stderr elsewhere in the code.
## TODO: Generalize this to other special files too (make a global list of such files)
## TODO: We actually want to add these to the read-write sets, but then don't take them
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gliargovas could you move this out of trace.py? I think it makes more sense for trace to just talk about how to parse the trace instead of having resolution logic. I think READ-WRITE set resolution should ignore dev/tty.

@angelhof
Copy link
Copy Markdown
Member

angelhof commented May 3, 2023

Merging this PR because it has far surpassed its goal. @gliargovas successfully parses the traces now and the issue with the CI doesn't have to do with these changes but is general and has to do with a combination of overlayfs and the CI itself. All tests pass locally.

@angelhof angelhof merged commit a892068 into main May 3, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2023

OS:ubuntu-20.04
Wed May 3 19:09:12 UTC 2023
Summary: 3/22 tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants