Conversation
|
OS:ubuntu-22.04 |
|
OS:ubuntu-22.04 |
|
OS:ubuntu-22.04 |
|
OS:ubuntu-22.04 |
|
OS:ubuntu-22.04 |
|
OS:ubuntu-22.04 |
|
OS:ubuntu-22.04 |
|
OS:ubuntu-22.04 |
|
OS:ubuntu-22.04 |
|
OS:ubuntu-22.04 |
|
OS:ubuntu-20.04 |
|
OS:ubuntu-20.04 |
| ## so we never want to keep /dev/tty in the read-write sets of any node. | ||
| ## We take care of writes to stdout and stderr elsewhere in the code. | ||
| ## TODO: Generalize this to other special files too (make a global list of such files) | ||
| ## TODO: We actually want to add these to the read-write sets, but then don't take them |
There was a problem hiding this comment.
@gliargovas could you move this out of trace.py? I think it makes more sense for trace to just talk about how to parse the trace instead of having resolution logic. I think READ-WRITE set resolution should ignore dev/tty.
…oring variables hasn't yet happened
|
Merging this PR because it has far surpassed its goal. @gliargovas successfully parses the traces now and the issue with the CI doesn't have to do with these changes but is general and has to do with a combination of overlayfs and the CI itself. All tests pass locally. |
|
OS:ubuntu-20.04 |
No description provided.