Skip to content

Loop support#38

Merged
angelhof merged 34 commits intomainfrom
loop-support
May 11, 2023
Merged

Loop support#38
angelhof merged 34 commits intomainfrom
loop-support

Conversation

@angelhof
Copy link
Copy Markdown
Member

@angelhof angelhof commented Apr 27, 2023

This is still work in progress. Currently the loop context is passed to the scheduler, but the scheduler still only executes each loop body once.

We currently need to figure out how to reexecute the same node in a loop more than once. I think the way to implement this is to unroll loops in the partial order while executing (see attached picture), and never executing/stepping/speculating/commiting/frontiering the loop node. The loop nodes should act as barriers that cannot be committed and we will decide to unroll them at some points. We can be conservative and just unroll the loop when the frontier is empty (which means that the next non-committed node is a loop node) or unroll it optimistically allowing speculation too.

IMG_0503

TODO before merging:

  • follow pash future branch
  • delete loop.sh and move to a test

@github-actions
Copy link
Copy Markdown

OS:ubuntu-22.04
Thu Apr 27 23:50:55 UTC 2023
Summary: 3/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2023

OS:ubuntu-20.04
Wed May 3 20:19:12 UTC 2023
Summary: 3/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2023

OS:ubuntu-20.04
Thu May 4 17:37:55 UTC 2023
Summary: 3/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2023

OS:ubuntu-20.04
Thu May 4 19:50:32 UTC 2023
Summary: 3/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2023

OS:ubuntu-20.04
Thu May 4 20:17:07 UTC 2023
Summary: 3/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2023

OS:ubuntu-20.04
Thu May 4 21:29:44 UTC 2023
Summary: 3/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2023

OS:ubuntu-20.04
Thu May 4 21:58:59 UTC 2023
Summary: 3/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2023

OS:ubuntu-20.04
Thu May 4 22:08:34 UTC 2023
Summary: 3/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2023

OS:ubuntu-20.04
Mon May 8 20:15:24 UTC 2023
Summary: 3/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2023

OS:ubuntu-20.04
Mon May 8 20:36:42 UTC 2023
Summary: 3/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2023

OS:ubuntu-20.04
Mon May 8 21:24:19 UTC 2023
Summary: 3/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2023

OS:ubuntu-20.04
Mon May 8 21:57:12 UTC 2023
Summary: 3/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2023

OS:ubuntu-20.04
Mon May 8 22:16:32 UTC 2023
Summary: 3/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2023

OS:ubuntu-20.04
Mon May 8 22:30:28 UTC 2023
Summary: 3/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2023

OS:ubuntu-20.04
Mon May 8 22:50:00 UTC 2023
Summary: 3/22 tests passed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2023

OS:ubuntu-20.04
Tue May 9 14:04:46 UTC 2023
Summary: 3/22 tests passed.

@github-actions
Copy link
Copy Markdown

OS:ubuntu-20.04
Wed May 10 15:03:10 UTC 2023
Summary: 1/23 tests passed.

@github-actions
Copy link
Copy Markdown

OS:ubuntu-20.04
Wed May 10 15:19:51 UTC 2023
Summary: 1/23 tests passed.

@angelhof angelhof changed the title [WIP] Loop support Loop support May 10, 2023
@github-actions
Copy link
Copy Markdown

OS:ubuntu-20.04
Wed May 10 15:41:48 UTC 2023
Summary: 2/23 tests passed.

@github-actions
Copy link
Copy Markdown

OS:ubuntu-20.04
Wed May 10 15:50:45 UTC 2023
Summary: 3/23 tests passed.

@github-actions
Copy link
Copy Markdown

OS:ubuntu-20.04
Thu May 11 14:27:05 UTC 2023
Summary: 1/23 tests passed.

@angelhof angelhof merged commit 1328ab6 into main May 11, 2023
@angelhof angelhof deleted the loop-support branch May 11, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant