Merged
Conversation
angelhof
requested changes
Dec 5, 2022
Member
angelhof
left a comment
angelhof
left a comment
There was a problem hiding this comment.
in general it looks good, but I think adding more comments and documentation is pretty important to understand why this works.
|
|
||
| # TODO: use unshare instead of chroot | ||
| # Alternatively, have a look at this | ||
| # NOTE: installed version of unshare does not support --root option |
Member
There was a problem hiding this comment.
It is OK to use chroot here (we can leave a more precise TODO to investigate the security implications of not doing an unshare together with the chroot and how could an adversary cause issues here).
|
|
||
| ls / | xargs -I '{}' mount -t overlay overlay -o lowerdir=/'{}',upperdir=$PWD/$pt/upperdir/'{}',workdir=$PWD/$pt/workdir/'{}' $PWD/$pt/temproot/'{}' | ||
|
|
||
| # TODO: use unshare instead of chroot |
Member
There was a problem hiding this comment.
I am not sure if we ever said to use unshare instead of chroot. I thought we said to use them together(?)
angelhof
approved these changes
Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.