Skip to content

43 add more repetition checks for tests#46

Merged
angelhof merged 13 commits intomainfrom
43-add-more-repetition-checks-for-tests
Jun 9, 2023
Merged

43 add more repetition checks for tests#46
angelhof merged 13 commits intomainfrom
43-add-more-repetition-checks-for-tests

Conversation

@gliargovas
Copy link
Copy Markdown
Collaborator

No description provided.

@gliargovas gliargovas added the ready for review This pull request is ready for review label May 23, 2023
@gliargovas gliargovas requested a review from angelhof May 23, 2023 16:17
@gliargovas gliargovas linked an issue May 23, 2023 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

OS:ubuntu-20.04
Tue May 23 16:23:19 UTC 2023
Summary: 0/23 tests passed.

@angelhof
Copy link
Copy Markdown
Member

Looks good to me, thanks! we can merge as long as the timing in tests is robust (if the tests pass with very high probability on atlas+cloudlab due to timing).

@github-actions
Copy link
Copy Markdown

OS:ubuntu-20.04
Wed May 24 14:33:19 UTC 2023
Summary: 0/23 tests passed.

@angelhof
Copy link
Copy Markdown
Member

@gliargovas Are we close to merging this? What is its status?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 6, 2023

OS:ubuntu-20.04
Tue Jun 6 11:10:34 UTC 2023
Summary: 0/23 tests passed.

@gliargovas
Copy link
Copy Markdown
Collaborator Author

@angelhof tests pass both locally and on cloudlab. Commented-out anything inconsistent. Feel free to merge :-)

@angelhof
Copy link
Copy Markdown
Member

angelhof commented Jun 6, 2023

Great, looks good. @gliargovas Could you first merge with main (git fetch --all; git merge origin/main) and rerun the tests on your machine? I have merged some PRs in main and I just want to make sure that when merging nothing has broken. If tests pass, feel free to merge :)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 9, 2023

OS:ubuntu-20.04
Fri Jun 9 10:40:47 UTC 2023
Summary: 4/24 tests passed.

@gliargovas
Copy link
Copy Markdown
Collaborator Author

@angelhof Made a minor change to the log level of the repetitions check (previously TRACE, now DEBUG). Tests pass and are consistent. Feel free to merge :-)

@angelhof angelhof merged commit 2109257 into main Jun 9, 2023
@angelhof angelhof deleted the 43-add-more-repetition-checks-for-tests branch June 9, 2023 14:37
@angelhof
Copy link
Copy Markdown
Member

angelhof commented Jun 9, 2023

Great, merged, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review This pull request is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more repetition checks for tests

2 participants