Conversation
|
OS:ubuntu-20.04 |
gliargovas
force-pushed
the
support-for-local-assignments
branch
from
8f9c7e2 to
aa3d839
Compare
|
OS:ubuntu-20.04 |
|
OS:ubuntu-20.04 |
gliargovas
added
ready for review
|
@angelhof Original test break passes, however, I noticed that commands after the loop will not execute. This behavior is similar to the main branch. We need to resolve this issue, but maybe in a separate PR. |
|
OS:ubuntu-20.04 |
| 'PASH_TOP', 'PASH_TOP_LEVEL','RANDOM', 'LOGNAME', 'MACHTYPE', 'MOTD_SHOWN', 'OPTERR', 'OPTIND', | ||
| 'PPID', 'PROMPT_COMMAND', 'PS4', 'SHELL', 'SHELLOPTS', 'SHLVL', 'TERM', 'UID', 'USER', 'XDG_SESSION_ID'} | ||
|
|
||
| SIGNIFICANT_VARS = {'foo', 'bar', 'baz'} |
There was a problem hiding this comment.
Add a TODO to not have significant vars and only have insignificant vars
| return True | ||
|
|
||
|
|
||
| def parse_env_string_to_dict(content): |
There was a problem hiding this comment.
Is this parsing/comparison complete? Or should we just use diff to check the envs
There was a problem hiding this comment.
I am pretty scared of this diff/parse. Let's add a comment that it might be problematic. I don't think regular expressions can correctly parse this file.
There was a problem hiding this comment.
We can leave it as is for now but down the line we need to consider how to do the diffing properly!
angelhof
left a comment
angelhof
left a comment
There was a problem hiding this comment.
@gliargovas No need to resolve all comments before merging if this PR is blocking. Keep some comments/notes and then merge if needed :)
| #!/bin/bash | ||
|
|
||
| ## TODO: Pass speculate flag here instead of separate scripts | ||
| # TODO: There is a bug here and parsing of RW dependencies doesn't really work |
There was a problem hiding this comment.
Is that comment relevant anymore? I would delete it I think
| return True | ||
|
|
||
|
|
||
| def parse_env_string_to_dict(content): |
There was a problem hiding this comment.
I am pretty scared of this diff/parse. Let's add a comment that it might be problematic. I don't think regular expressions can correctly parse this file.
| return True | ||
|
|
||
|
|
||
| def parse_env_string_to_dict(content): |
There was a problem hiding this comment.
We can leave it as is for now but down the line we need to consider how to do the diffing properly!
|
OS:ubuntu-20.04 |
2 participants
As of now, all tests except for
test_breakpass locally.